[Apt-Rpm] [PATCH] Make it build with rpm 5.2 again

[Panu Matilainen]

On Tue, 18 Nov 2008, Bernhard Rosenkraenzer wrote:

> Hi,
> the recent changes in git broke rpm 5.2 support - the
> attached
> patch fixes it (I hope it doesn't break rpm 4.x -- in theory it
> shouldn't, but I don't have an rpm4 installation to check on).

Please change this to use "capability" checks instead. Rpm versions don't 
mean a thing these days, the only semi-safe range for rpm versions is < 
4.4.2 and even there differences exist as vendors have patched rpm all 
over.

One simple possibility would seem to be checking for rpm4compat.h 
existence, rpm.org uses rpmlegacy.h for similar purpose so it's easy to 
distinguish between the two.

Another thing is that I'd like to see these compatibility #ifdef's grouped 
into one place as much as possible to get them out of sight. rapttypes.h 
is a start towards that direction but obviously a LOT more work is needed, 
the compatibility cruft has spread all over apt-pkg/rpm/ directory over 
the years.

Then of course apt-rpm can't be stuck forever on the legacy 
compatibility wrappers but that's another story...

 	- Panu -