[Apt-Rpm] [PATCH]: rpm 5.0 support
Panu Matilainen
pmatilai at laiskiainen.org
Sat Apr 19 23:56:18 PDT 2008
Sorry for the very very late response :-/
On Wed, 5 Mar 2008, Per Øyvind Karlsen wrote:
> På Mandag 03 mars 2008 , 02:28:00 skrev Per Øyvind Karlsen:
>> På Mandag 03 mars 2008 , 01:57:45 skrev Per Øyvind Karlsen:
>>> Hi!
>>>
>>> This patch is quite simple as the real work was rather done on a wrapper
>>> at rpm5.org upstream, so it basically mostly adds inclusion of this
>>> header before any other rpm headers. As you can see it will remove
>>> inclusion of rpmlib.h in some files, but this is only since the file gets
>>> included in another header included later and it's important that the
>>> rpm4compat.h header gets included before rpmlib.h. Also to ensure that
>>> RPM_VERSION is defined, config.h has been added where missing and needed
>>> as well.
>>>
>>> Finally there's a tiny bug fix where 'int' has been used in stead of
>>> 'int_32', this leads to problem with rpm 5.0 since unsigned int
>>> (uint32_t) are used in stead, so since int_32 gets typedef'd to uint32_t
>>> in rpm4compat.h...
>>>
>>> As I don't use apt-get myself, I haven't really tested apt-get with rpm
>>> 5.0 besides getting it to build without warnings, but I would assume that
>>> it should work mostly okay, at least urpmi works just fine with this
>>> compatibility wrapper.. :)
>>
>> grf, here's the correct patch :p
>
> This one is a bit better since it avoids need of silly wrapper function in
> rpm5compat.h just to typecast from unsigned long long to uint64_t..
Thanks. I'll include in some form, but checking for rpm versions doesn't
cut it anymore for these kind of things (it'd work today, but...),
we need checks on capabilities instead of versions.
- Panu -
More information about the Apt-Rpm
mailing list