[Apt-Rpm] 0.5.15lorg3.93 Solaris build issue

[João Abecasis]

Hi David,

I don't want to lead you on the wrong path, but I'll offer my
suggestions and hope they help. Take them with a grain of salt.

David Halik wrote:
> +#ifndef __GNUC__
> +#define *__attribute__*(X)
> +#endif

Are the **s above intentional? They should not be there.

Where did you add the snippet? You must #define the macro before it is
used anywhere in the code. Your compiler should have an option to do
this from the command line.

You could also try removing the __attribute__ decorations by hand on
lines 51-53 of both include/apt-pkg/sha1.h and apt-pkg/contrib/sha1.h:

   /* assumes 64-bit alignment just in case */
   unsigned char Buffer[64] /* __attribute__((aligned(8))) */;
   unsigned char State[5*4] /* __attribute__((aligned(8))) */;
   unsigned char Count[2*4] /* __attribute__((aligned(8))) */;

The accompanying comment seems to imply the alignment is not strictly
necessary. Anyway, I think you should look into alternatives to force
the alignment of those variables, "just in case". :-)

Best regards,


João Abecasis