WITH_HASH_MAP

Panu Matilainen pmatilai at laiskiainen.org
Thu Jun 29 09:11:05 PDT 2006


On Thu, 2006-06-29 at 18:00 +0200, Ralf Corsepius wrote:
> On Thu, 2006-06-29 at 18:33 +0300, Panu Matilainen wrote:
> > On Wed, 2006-06-28 at 16:55 +0200, Ralf Corsepius wrote:
> > > On Wed, 2006-06-28 at 16:18 +0200, Ralf Corsepius wrote:
> > > > On Wed, 2006-06-28 at 06:25 -0700, Panu Matilainen wrote:
> > > > > On Wed, 28 Jun 2006, Ralf Corsepius wrote:
> > > 
> > > > > All that's needed is s/WITH_HASH_MAP/WITH_GNU_HASH_MAP/ in the rpm 
> > > > > directory to resurrect the thing that's supposed to have been enabled all 
> > > > > these years (been unused since March 2003).
> > > 
> > > The patch below implements what you outline above.
> > 
> > Why use two separate ifdef's for this when one would do just fine?
> 
> "one" is not fine. It changes the initialization order.
> 
> Switch add -W to CXXFLAGS and you'll see GCC warn about it.
> 
> An alternative to these 2 #ifdefs would be to change the order inside of
> the header.

Ah, ok then. Applied for now, lets see if it buys us anything :)

	- Panu -




More information about the Apt-Rpm mailing list